Repository navigation
WIP: Private key management chapter - #48
Merged
Merged
Conversation
Moving content from the Google Doc to Github.
- Minor copy fixes (typos, grammar etc)
alphabetising the glossary
completed alphabetising the glossary
Alphabetised Feature/glossary
danielnordh
marked this pull request as draft
November 17, 2020 09:39
Accepted. Co-authored-by: Johns Beharry <johns@peakshift.com>
Contributor
|
ACK. Reviewed yesterday and today and gave a lot of feedback. This is a fantastic first version we can put live. I found it super helpful to have these ideas clearly laid out. A few ideas for follow-up tasks after merge that can be handled separately:
|
Typo Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Christoph Ono <chri@sto.ph>
Co-authored-by: Johns Beharry <johns@peakshift.com>
Co-authored-by: Johns Beharry <johns@peakshift.com>
Co-authored-by: Johns Beharry <johns@peakshift.com>
Co-authored-by: Johns Beharry <johns@peakshift.com>
Co-authored-by: Johns Beharry <johns@peakshift.com>
Co-authored-by: Johns Beharry <johns@peakshift.com>
Co-authored-by: Johns Beharry <johns@peakshift.com>
Co-authored-by: Johns Beharry <johns@peakshift.com>
…nDesign/Guide into private-key-management-v1
Contributor
|
Congratulations on this ,seriously! 🚀 🚀 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a working branch for the private key management chapter.
Edit
I now believe it is in good enough shape for an MVP, so ready for merging feedback!